Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winch x64 rmw sub #10008

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

MarinPostma
Copy link
Contributor

@MarinPostma MarinPostma commented Jan 14, 2025

impl read-modify-write sub for winch:

  • i32.atomic.rmw8.subd_u
  • i32.atomic.rmw16.subd_u
  • i32.atomic.rmw.subd
  • i64.atomic.rmw8.subd_u
  • i64.atomic.rmw16.subd_u
  • i64.atomic.rmw32.subd_u
  • i64.atomic.rmw.subd

#9734

depends on #9990

@MarinPostma MarinPostma requested review from a team as code owners January 14, 2025 11:30
@MarinPostma MarinPostma requested review from abrown and alexcrichton and removed request for a team January 14, 2025 11:30
@github-actions github-actions bot added the winch Winch issues or pull requests label Jan 14, 2025
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@MarinPostma MarinPostma force-pushed the winch-x64-rmw-sub branch 2 times, most recently from d94f17e to 777f3a7 Compare January 14, 2025 13:50
@saulecabrera
Copy link
Member

I'll take this one.

@saulecabrera saulecabrera requested review from saulecabrera and removed request for abrown and alexcrichton January 14, 2025 20:57
@saulecabrera
Copy link
Member

@MarinPostma I'll take a look once this is rebased on top of #9990 and on top of #9987, since this requires using emit_compute_heap_address_align_checked

@MarinPostma
Copy link
Contributor Author

@saulecabrera this one is rebased too.

@saulecabrera
Copy link
Member

You need to rebase, since there are some conflicts.

@MarinPostma
Copy link
Contributor Author

@saulecabrera done

@saulecabrera saulecabrera added this pull request to the merge queue Jan 16, 2025
Merged via the queue into bytecodealliance:main with commit c72de0b Jan 16, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants